DM-45815: Add utility functions to access gain and readnoise #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadrlica
force-pushed
the
tickets/DM-45815
branch
from
c428f6b
to
01580aa
Compare
|
Jenkins build #2490. |
kadrlica
force-pushed
the
tickets/DM-45815
branch
from
01580aa
to
effd66b
Compare
|
@Alex-Broughton would you be able to review this? |
|
Sure let me take a look.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Alex Drlica-Wagner ***@***.***>
Sent: Sunday, September 29, 2024 7:06:24 AM
To: lsst/ip_isr ***@***.***>
Cc: Alex Broughton ***@***.***>; Mention ***@***.***>
Subject: Re: [lsst/ip_isr] DM-45815: Add utility functions to access gain and readnoise (PR #340)
@Alex-Broughton<https://github.com/Alex-Broughton> would you be able to review this?
—
Reply to this email directly, view it on GitHub<#340 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHRE2YUAHUI7QMPR35U33A3ZZACOBAVCNFSM6AAAAABMUPD4NCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGM3TAOBVGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preferred values of the gain and read noise are currently being set in header keys. We'd like to provide access functions to avoid making the user know the precise header keyword prefixes (which are changing with the new isrTask).